Fix deadline enforcement: check has_deadline, use block timestamp#810
Merged
realproject7 merged 1 commit intomainfrom Apr 3, 2026
Merged
Fix deadline enforcement: check has_deadline, use block timestamp#810realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Critical: deadline logic was incorrectly blocking storylines without deadlines (has_deadline=false). 1. AddPlotButton: skip deadline check when hasDeadline is false 2. Create page: isStorylineExpired checks has_deadline before time check 3. API indexer: select has_deadline, skip check when false; use block timestamp instead of Date.now() to avoid rejecting plots the contract already accepted near the deadline edge Fixes #808 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes both deadline-regression paths from issue #808. The has_deadline gate is now applied consistently in the button, create flow, and API, and the API deadline check now compares against the transaction's block timestamp instead of wall-clock time.
Findings
- No blocking findings.
Decision
Approving. This satisfies the critical acceptance criteria for issue #808 and removes the false blocking introduced by PR #807.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Critical fix: PR #807's deadline enforcement was incorrectly blocking storylines with
has_deadline=false.Bug 1 Fix:
has_deadlinecheck addedAddPlotButton.tsx: skips deadline check whenhasDeadlineis falsecreate/page.tsx:isStorylineExpired()checkss.has_deadlinebefore time comparisonapi/index/plot/route.ts: selectshas_deadline, skips deadline check when falseBug 2 Fix: Block timestamp instead of
Date.now()blockTimestamp(when tx was mined) vs deadline, notDate.now()— prevents rejecting plots the contract already accepted near the deadline edgeTest Plan
has_deadline=false: button clickable, dropdown selectable, API acceptshas_deadline=true+ expired: button disabled, dropdown disabled, API rejectshas_deadline=true+ active: all works normallyFixes #808
🤖 Generated with Claude Code